Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: users can see inaccessible RPs #7707

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

eecsliu
Copy link
Contributor

@eecsliu eecsliu commented Aug 22, 2023

Description

There was previously no distinction between RPs with no bindings, and RPs that a user did not have access to, as both would appear to have no bindings. As of this PR, if a user does not have access to a workspace that is bound to a resource pool, we should be able to detect it and return a not found error.

Test Plan

using two workspaces (A and B), bind A to a resource pool. create a user with edit access to B, and use the CLI command det rp bindings list-workspaces <resource pool name>. You should get an error that the resource pool "does not exist or is not available to view".

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@eecsliu eecsliu requested a review from a team as a code owner August 22, 2023 21:07
@eecsliu eecsliu requested review from erikwilson and removed request for a team August 22, 2023 21:07
@cla-bot cla-bot bot added the cla-signed label Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 6e21b56
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/64e523927f01220008b0bbad
😎 Deploy Preview https://deploy-preview-7707--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eecsliu eecsliu merged commit 2fd2535 into main Aug 22, 2023
74 of 85 checks passed
@eecsliu eecsliu deleted the fix-rp-bindings-see-inaccessible-rp branch August 22, 2023 22:17
@dannysauer dannysauer added this to the 0.25.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants