fix: compare charts showing no data while loading [WEB-1485] #7516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -27,6 +29,7 @@ const useMetricNames = ( | |||
| setMetrics(Loaded([])); | |||
| return; | |||
| } | |||
| if (!isEqual(actualExpIds, previousExpIds)) setMetrics(NotLoaded); | |||
There was a problem hiding this comment.
Currently, when the ExpIds change the metrics are still set as Loaded which causes us to show the No Data To Plot message since metrics may have not been loaded for the newly selected experiments.
| if (!isLoaded) { | ||
| // When trial metrics hasn't loaded metric names or individual trial metrics. | ||
| return NotLoaded; | ||
| } else if (!chartDataIsLoaded || !isEqual(selectedMetrics, metrics)) { |
There was a problem hiding this comment.
the reason I added the !isEqual(selectedMetrics, metrics)) check is because one bug I was seeing is that when selecting new experiments sometimes for a split second the UI would show no data to plot. I tracked down the issue being that:
- A user selects a new experiment
- The new metric names are queried for both the current experiments and new one
- Eventually a call to
summarizedMetricToSeriesis made but the input metrics do not include all the new metrics from (1). - We show
no data to plotsince we think the new metrics from (1) do not have any data, but actually we have not searched for them yet.
The isEqual check ensures that the metrics that were searched for matches the currently selected metrics.
mapmeld
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Charts in the "compare" view should always show a loading state until metrics have been successfully loaded for the selected experiments.
4DC29112-B338-4373-8DFB-3027AA76422B.mov
Test Plan
no data to plot.select first 25ensure that while the charts are loading you do not seeno data to plotever.Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
WEB-1485