Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Conda bump #7479

Merged
merged 6 commits into from
Jul 26, 2023
Merged

ci: Conda bump #7479

merged 6 commits into from
Jul 26, 2023

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Jul 26, 2023 •
edited
Loading

Description

Fix install_python.sh script. Conda no longer supports requests<2.27.0, but the particular version of conda that we were using is force installing requests==2.25.1. Bump conda version to latest stable.

Test Plan

test_intg must be green.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2023
@netlify
Copy link

netlify bot commented Jul 26, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 81fa240
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/64c15a0a8a87730008264ca9

@MikhailKardash MikhailKardash marked this pull request as ready for review July 26, 2023 17:38
@MikhailKardash MikhailKardash changed the title ci: Requests bump ci: Conda bump Jul 26, 2023
@MikhailKardash MikhailKardash requested a review from ioga July 26, 2023 17:40
hkang1
hkang1 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triple approval!

@MikhailKardash MikhailKardash merged commit ebac1d3 into main Jul 26, 2023
20 of 22 checks passed
@MikhailKardash MikhailKardash deleted the requests_bump branch July 26, 2023 17:54
@NicholasBlaskey NicholasBlaskey added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 26, 2023
dai-release bot pushed a commit that referenced this pull request Jul 26, 2023
@MikhailKardash @determined-ci
ci: Conda bump (#7479)
ed19b69 
* bump conda version to latest stable

* replace md5 checksum with sha256

(cherry picked from commit ebac1d3)
@dannysauer dannysauer added this to the 0.24.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkang1 hkang1 hkang1 approved these changes

@ioga ioga ioga approved these changes

@stoksc stoksc stoksc approved these changes

Assignees

@MikhailKardash MikhailKardash

Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MikhailKardash @hkang1 @ioga @stoksc @dannysauer @NicholasBlaskey