Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GC task spec's ResourcesConfig should be valid #6366

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: GC task spec's ResourcesConfig should be valid #6366

merged 1 commit into from
Mar 28, 2023

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Mar 27, 2023 •
edited
Loading

Description

CheckpointGC's TaskSpec has a ResourceConfigV0 that is not properly instantiated, so its use caused panics in Slurm code.

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@stoksc stoksc requested a review from a team as a code owner March 27, 2023 20:56
@cla-bot cla-bot bot added the cla-signed label Mar 27, 2023
@stoksc stoksc merged commit 2f57cd6 into determined-ai:master Mar 28, 2023
@stoksc stoksc deleted the checkpoint-gc-task-resources-valid branch March 28, 2023 12:24
@dannysauer dannysauer added this to the 0.21.1 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwilson erikwilson erikwilson approved these changes

@jerryharrow jerryharrow jerryharrow approved these changes

@CanmingCobble CanmingCobble CanmingCobble approved these changes

Assignees

@jerryharrow jerryharrow

Labels
cla-signed
Projects
None yet
Milestone
0.21.1
Development

Successfully merging this pull request may close these issues.
5 participants
@stoksc @erikwilson @jerryharrow @CanmingCobble @dannysauer