Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace card issue #6320

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Mar 22, 2023

Description

WEB-1084

Screen.Recording.2023-03-22.at.4.39.10.PM.mov

Test Plan

  • Go to workspaces
  • Click on “Edit” from a workspace card’s dropdown
  • Check if clicking outside the modal to dismiss the modal and clicking on the modal doesn't cause page transition

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit a96340c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/641b939da7a63300084c5663
😎 Deploy Preview https://deploy-preview-6320--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@keita-determined keita-determined marked this pull request as ready for review March 22, 2023 23:47
</div>
</div>
</div>
</Card>
{contextHolders}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just moved out {contextHolders} from Card component because that caused the issue

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keita-determined keita-determined merged commit 61513e4 into master Mar 23, 2023
@keita-determined keita-determined deleted the fix/workspace-card-issue branch March 23, 2023 17:14
hanyucui pushed a commit that referenced this pull request Mar 23, 2023
(cherry picked from commit 61513e4)
@dannysauer dannysauer added this to the 0.21.1 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants