Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Sphinx theme #80

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Test Sphinx theme #80

merged 9 commits into from
Apr 15, 2024

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Sep 15, 2023

Switch docs to Awesome Sphinx Theme to test it.

@jank324 jank324 self-assigned this Sep 15, 2023
@jank324 jank324 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 15, 2023
@jank324 jank324 marked this pull request as ready for review April 13, 2024 09:41
@jank324 jank324 marked this pull request as draft April 13, 2024 09:43
@jank324 jank324 marked this pull request as ready for review April 13, 2024 09:43
@jank324 jank324 requested a review from cr-xu April 13, 2024 09:43
@cr-xu
Copy link
Member

cr-xu commented Apr 15, 2024

Somehow it shows merging is blocked for me
image
But this seems just a fast-forward. Also, we didn't change any branch protection rules, right?

@jank324
Copy link
Member Author

jank324 commented Apr 15, 2024 •
edited
Loading

Somehow it shows merging is blocked for me image But this seems just a fast-forward. Also, we didn't change any branch protection rules, right?

It says the same for me ... I really don't see why though. Maybe it's because the PR is very old?

I'm inclined to bypass the branch protections for this one if you also don't see any reasons why we shouldn't.

@jank324
Copy link
Member Author

jank324 commented Apr 15, 2024

We didn't change the branch protection rules recently. But given the age of the PR, it is possible we changed them since creating it.

@cr-xu
Copy link
Member

cr-xu commented Apr 15, 2024

It says the same for me ... I really don't see why though. Maybe it's because the PR is very old?

I'm inclined to bypass the branch protections for this one if you also don't see any reasons why we shouldn't.

Sounds good, let's just do that.

@jank324 jank324 merged commit 71a52c6 into master Apr 15, 2024
9 checks passed
@jank324 jank324 deleted the test-sphinx-theme branch April 15, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr-xu cr-xu cr-xu approved these changes

Assignees

@jank324 jank324

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jank324 @cr-xu