Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vectorization issue in rbend #173

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

cr-xu
Copy link
Member

@cr-xu cr-xu commented Jun 12, 2024

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line

@cr-xu cr-xu added the bug Something isn't working label Jun 12, 2024
@cr-xu cr-xu linked an issue Jun 12, 2024 that may be closed by this pull request
@cr-xu cr-xu requested a review from jank324 June 12, 2024 15:47
Comment on lines 106 to 107
# non_zero_mask = self.length != 0
# value[non_zero_mask] = self.angle[non_zero_mask] / self.length[non_zero_mask]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# non_zero_mask = self.length != 0
# value[non_zero_mask] = self.angle[non_zero_mask] / self.length[non_zero_mask]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is there a reason those comments should be there?

@jank324
Copy link
Member

jank324 commented Jun 12, 2024

Also, the PR number should be added to the changelog entry.

@jank324
Copy link
Member

jank324 commented Jun 13, 2024

@cr-xu if you didn't have an important reason to keep the comment, I think this PR can now just be merged as is.

@cr-xu
Copy link
Member Author

cr-xu commented Jun 13, 2024

Thanks for the changes! I forgot to remove the comments.

@cr-xu cr-xu merged commit ff3430b into master Jun 13, 2024
11 checks passed
@jank324 jank324 deleted the 171-vectorization-error-in-rbend branch June 13, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vectorization error in RBend
2 participants