Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize & Add youtube embed links support #456

Merged
merged 4 commits into from
May 21, 2024

Conversation

reda777
Copy link
Contributor

@reda777 reda777 commented Apr 19, 2024

I made the /embed command work with "https://www.youtube.com/embed/*" links, and fixed what I think is repeated code.

Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run unit tests with npm run test, you'll notice that the tests related to live, short, and embed YouTube URLs fail now. Would you mind looking into this?

@11k 11k added the enhancement New feature or request label May 21, 2024
@reda777 reda777 requested a review from 11k May 21, 2024 11:00
assets/chat/js/hashlinkconverter.js Outdated Show resolved Hide resolved
@reda777 reda777 requested a review from 11k May 21, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants