Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 284 Add embed button on embeddable links #285

Merged
merged 17 commits into from
Aug 30, 2023
Merged

Conversation

Riott
Copy link
Contributor

@Riott Riott commented Jun 14, 2023

Adds a small button to embed on links that have an embeddable link.
image

Resolves #284

Draft while I get feedback

Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a TV icon is fine. You can use an inline SVG.

assets/chat/js/chat.js Outdated Show resolved Hide resolved
assets/chat/js/hashlinkconverter.js Outdated Show resolved Hide resolved
assets/chat/js/formatters/UrlFormatter.js Outdated Show resolved Hide resolved
@Riott
Copy link
Contributor Author

Riott commented Aug 8, 2023

I'll look at addressing these this week if not today at some point :)

@Riott Riott requested a review from 11k August 8, 2023 15:58
@Riott Riott marked this pull request as ready for review August 8, 2023 16:00
assets/chat/js/formatters/UrlFormatter.js Outdated Show resolved Hide resolved
@Riott Riott requested a review from 11k August 30, 2023 00:54
assets/chat/js/formatters/UrlFormatter.js Outdated Show resolved Hide resolved
@Riott Riott requested a review from 11k August 30, 2023 01:06
@11k 11k merged commit a3bbd01 into destinygg:master Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having to convert an embeddable URL into a hash link for click-to-embed behavior is clumsy
2 participants