Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio-caption SC tag #721

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Fix audio-caption SC tag #721

merged 1 commit into from
Feb 8, 2018

Conversation

WilcoFiers
Copy link
Contributor

Closes #686

@WilcoFiers WilcoFiers merged commit 9c7b9f1 into develop Feb 8, 2018
@WilcoFiers WilcoFiers deleted the audio-caption-tag branch February 8, 2018 03:24
@chaals
Copy link
Contributor

chaals commented Mar 28, 2018

Don't the tests also apply to 1.2.2, 1.2.4, and 1.2.9?

(I am not sure if I misunderstood the tag system though)

@WilcoFiers
Copy link
Contributor Author

@chaals I don't think it does. Those are video SCs, this is audio only.

@chaals
Copy link
Contributor

chaals commented Mar 29, 2018

But they require, for video which includes audio (or for live-streamed audio in the case of 1.2.9 I think), audio captions - i.e. the same requirement.

(if they do apply, am I making the right assumption that multiple checkpoint tags should be applied?)

@WilcoFiers
Copy link
Contributor Author

The audio-caption rule only checks <audio> elements. I don't see how 1.2.2 says:

all prerecorded audio content in synchronized media

There's a slight assumption we are making that the <audio> element isn't synchronised with something else on the page, but I think that's generally not the case. So 99% of the time I would say this only applies to 1.2.1. Also as a rule of thumb, we use one SC, not all that may be applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants