style(lib/rules): var -> const & let

lib/rules/data-table-large-matches.js

@@ -2,7 +2,7 @@ import { isDataTable, toArray } from '../commons/table';
 
 function dataTableLargeMatches(node) {
   if (isDataTable(node)) {
-    var tableArray = toArray(node);
+    const tableArray = toArray(node);
     return (
       tableArray.length >= 3 &&
       tableArray[0].length >= 3 &&

lib/rules/frame-title-has-text-matches.js

@@ -1,7 +1,7 @@
 import { sanitize } from '../commons/text';
 
 function frameTitleHasTextMatches(node) {
-  var title = node.getAttribute('title');
+  const title = node.getAttribute('title');
   return !!sanitize(title);
 }
 

lib/rules/label-matches.js

@@ -6,7 +6,7 @@ function labelMatches(node, virtualNode) {
     return true;
   }
 
-  var type = virtualNode.attr('type').toLowerCase();
+  const type = virtualNode.attr('type').toLowerCase();
   return (
     ['hidden', 'image', 'button', 'submit', 'reset'].includes(type) === false
   );

lib/rules/landmark-unique-matches.js

@@ -1,8 +1,22 @@
 import { isVisibleToScreenReaders } from '../commons/dom';
+import { closest } from '../core/utils';
 import { getRole } from '../commons/aria';
 import { getAriaRolesByType } from '../commons/standards';
 import { accessibleTextVirtual } from '../commons/text';
 
+/*
+ * Since this is a best-practice rule, we are filtering elements as dictated by ARIA 1.1 Practices regardless of treatment by browser/AT combinations.
+ *
+ * Info: https://www.w3.org/TR/wai-aria-practices-1.1/#aria_landmark
+ */
+const excludedParentsForHeaderFooterLandmarks = [
+  'article',
+  'aside',
+  'main',
+  'nav',
+  'section'
+].join(',');
+
 export default function landmarkUniqueMatches(node, virtualNode) {
   return (
     isLandmarkVirtual(virtualNode) && isVisibleToScreenReaders(virtualNode)
@@ -17,6 +31,9 @@ function isLandmarkVirtual(vNode) {
   }
 
   const { nodeName } = vNode.props;
+  if (nodeName === 'header' || nodeName === 'footer') {
+    return isHeaderFooterLandmark(vNode);
+  }
 
   if (nodeName === 'section' || nodeName === 'form') {
     const accessibleText = accessibleTextVirtual(vNode);
@@ -25,3 +42,7 @@ function isLandmarkVirtual(vNode) {
 
   return landmarkRoles.indexOf(role) >= 0 || role === 'region';
 }
+
+function isHeaderFooterLandmark(headerFooterElement) {
+  return !closest(headerFooterElement, excludedParentsForHeaderFooterLandmarks);
+}

lib/rules/link-in-text-block-matches.js

@@ -2,8 +2,8 @@ import { sanitize } from '../commons/text';
 import { isVisibleOnScreen, isInTextBlock } from '../commons/dom';
 
 function linkInTextBlockMatches(node) {
-  var text = sanitize(node.innerText);
-  var role = node.getAttribute('role');
+  const text = sanitize(node.innerText);
+  const role = node.getAttribute('role');
 
   if (role && role !== 'link') {
     return false;

lib/rules/scrollable-region-focusable-matches.js

@@ -5,10 +5,10 @@ import { querySelectorAll, getScroll } from '../core/utils';
 export default function scrollableRegionFocusableMatches(node, virtualNode) {
   return (
     // The element scrolls
+    // And there's something actually worth scrolling to
     getScroll(node, 13) !== undefined &&
     // It's not a combobox popup, which commonly has keyboard focus added
     isComboboxPopup(virtualNode) === false &&
-    // And there's something actually worth scrolling to
     isNoneEmptyElement(virtualNode)
   );
 }

lib/rules/svg-namespace-matches.js

@@ -10,7 +10,8 @@ function svgNamespaceMatches(node, virtualNode) {
 
     // element is svg namespace if its parent is an svg element
     return !!closest(virtualNode, 'svg');
-  } catch {
+  } catch (e) {
+    console.debug(e);
     return false;
   }
 }