Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(lib/core): var -> let and const codemod #4457

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

gaiety-deque
Copy link
Contributor

Just like #4451 but for lib/core

This does add an .eslintignore line, perhaps we'd rather skip a file a different way.

Smaller part of the full vision: #4444

@gaiety-deque gaiety-deque marked this pull request as ready for review May 10, 2024 19:27
@gaiety-deque gaiety-deque requested a review from a team as a code owner May 10, 2024 19:27
@@ -7,5 +7,6 @@ doc/api/*
doc/examples/jest_react/*.js

lib/core/imports/*.js
lib/core/utils/uuid.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to include this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did @WilcoFiers. It felt weird to update a file that I don't think we wrote (judging by the comment at the top of uuid.js. Eventually when all of these codemods are merged the last PR will turn on the eslint rule no-var and unless we either update this file or ignore it, this file will throw an eslint warning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaiety-deque Merge conflict, can you update?

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the eslintignore thing. Rest looks good

@gaiety-deque gaiety-deque changed the base branch from develop to fix-flakey-marque-firefox-test May 17, 2024 19:18
Base automatically changed from fix-flakey-marque-firefox-test to develop May 20, 2024 13:01
@gaiety-deque gaiety-deque merged commit 68bae74 into develop Jun 6, 2024
22 checks passed
@gaiety-deque gaiety-deque deleted the var-to-let-libcore branch June 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants