Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rule aria-deprecated-role #4074

Merged
merged 6 commits into from
Jul 10, 2023
Merged

feat: add rule aria-deprecated-role #4074

merged 6 commits into from
Jul 10, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 29, 2023

Split out aria-deprecated-role from aria-roles into it's own rule.

Closes: #4069

@straker straker requested a review from a team as a code owner June 29, 2023 21:49
@@ -144,6 +144,7 @@
"html-entities": "1.x",
"http-server": "^14.1.1",
"husky": "^8.0.3",
"inquirer": "^8.2.5",
Copy link
Contributor Author

@straker straker Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed to run the rule generator. Not sure when it was removed.

lib/rules/aria-deprecated-role.json Outdated Show resolved Hide resolved
test/integration/rules/aria-roles/aria-roles.html Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously approved these changes Jul 4, 2023
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

lib/rules/aria-deprecated-role.json Outdated Show resolved Hide resolved
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
locales/_template.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put aria-deprecated-role (from aria-roles) into its own rule
2 participants