Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not warn when using webpack #3777

Merged
merged 5 commits into from
Nov 14, 2022
Merged

fix: do not warn when using webpack #3777

merged 5 commits into from
Nov 14, 2022

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 10, 2022

Following the steps in the ticket, this fixes the webpack output to not warn of the critical dependency. Seems something about esbuild v0.11+ causes the problem. For now this is a fix to the problem, but I'll investigate further at some later date to see if I can figure out what's going on.

image

Closes issue: #3771

@straker straker requested a review from a team as a code owner November 10, 2022 23:38
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to downgrade this. IMO we ought to consider using a different build tool. Is 0.10 maintained?

@TheJaredWilcurt
Copy link

Perhaps an issue should be created in the esbuild repo, so that this can be resolved there. Then once resolved, axe-core could update to the latest esbuild version with the fix. For now though, downgrading is the quickest/simplest solution.

@@ -1082,12 +1082,14 @@ describe('color.getBackgroundColor', function () {
it('returns the html background', function () {
fixture.innerHTML = '<div id="target"><label>elm<input></label></div>';
document.documentElement.style.background = '#0F0';
document.body.setAttribute('style', 'background: unset');
Copy link
Contributor Author

@straker straker Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Mocha added default styles to body in a recent update, one of which was a white background and black foreground. So needed to unset the background color for the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants