Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frame-title-unique): Make frame-title-unique reviewOnly and WCAG412 #3610

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

dbowling
Copy link
Contributor

Aze-core's frame-title-unique rule is currently inconsistent with ACT Rules because it is far too strict.

This makes the rule partially consistent with the Iframe elements with identical accessible names have equivalent purpose ACT rule.

  • add tags: wcag412 and wcag2a
  • remove tag: best-practice
  • add "reviewOnFail": true

references: #3487

@dbowling dbowling marked this pull request as ready for review August 16, 2022 23:44
@dbowling dbowling requested a review from a team as a code owner August 16, 2022 23:44
lib/rules/frame-title-unique.json Show resolved Hide resolved
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the Rule class change. This turned out more complicated than I expected it would be.

test/core/base/rule.js Outdated Show resolved Hide resolved
@dbowling dbowling dismissed WilcoFiers’s stale review August 24, 2022 05:10

after callback has been given own describe, and any/all/none cases each have tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants