Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get-background-color): No longer calculate color from non-opaque overlapping element #1644

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

roman-bytes
Copy link
Contributor

@roman-bytes roman-bytes commented Jun 20, 2019

…overlapping elm

Prevents calculating color contrast ratio that have an overlapping element

Closes issue: #1459

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@roman-bytes roman-bytes requested a review from a team June 20, 2019 14:09
@roman-bytes roman-bytes requested a review from a team as a code owner June 20, 2019 14:09
@AutoSponge
Copy link
Contributor

AutoSponge commented Jun 20, 2019

I'm worried this will ignore overlays that cause a problem. Is it possible we can only apply this rule to contents contained by the intert attribute or aria-hidden? Also, if that's the case, maybe we don't have to do the calculation at all, just skip the color contrast check all together.

@straker
Copy link
Contributor

straker commented Jun 20, 2019

Can you give an example of an overlay that causes a problem? One issue is that not all overlays are well written and inert or aria-hidden the rest of the page. Some will just focus trap (or not) the overlay without truly hiding everything else.

@AutoSponge
Copy link
Contributor

I'd argue that an incomplete (incorrect) implementation should get the color-contrast rule as-is. If they add inert/aria-hidden to a container, those elements can be exempt from this rule. The overlay I'm referring to is the one in the linked issue. Without looking at the implementation, I would need to make sure that there are no tab stops in the overlaid section (inert) before I said that contrast doesn't matter.

@straker straker changed the title fix(get-background-color): No longer calculate color from non-opaque … fix(get-background-color): No longer calculate color from non-opaque overlapping element Jun 20, 2019
@roman-bytes roman-bytes merged commit d45f81e into develop Jun 20, 2019
@stephenmathieson stephenmathieson deleted the color-contrast-overlap branch June 20, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants