Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(role-img-alt): Split rule for role=img with no accessible name #1586

Merged
merged 1 commit into from
May 24, 2019
Merged

feat(role-img-alt): Split rule for role=img with no accessible name #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/rule-descriptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
| page-has-heading-one | Ensure that the page, or at least one of its frames contains a level-one heading | Moderate | cat.semantics, best-practice | true |
| radiogroup | Ensures related <input type="radio"> elements have a group and that the group designation is consistent | Critical | cat.forms, best-practice | true |
| region | Ensures all page content is contained by landmarks | Moderate | cat.keyboard, best-practice | true |
| role-img-alt | Ensures [role='img'] elements have alternate text | Serious | cat.text-alternatives, wcag2a, wcag111, section508, section508.22.a | true |
| scope-attr-valid | Ensures the scope attribute is used correctly on tables | Moderate, Critical | cat.tables, best-practice | true |
| scrollable-region-focusable | Elements that have scrollable content should be accessible by keyboard | Moderate | wcag2a, wcag211 | true |
| server-side-image-map | Ensures that server-side image maps are not used | Minor | cat.text-alternatives, wcag2a, wcag211, section508, section508.22.f | true |
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/image-alt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "image-alt",
"selector": "img, [role='img']:not(svg)",
"selector": "img",
"tags": [
"cat.text-alternatives",
"wcag2a",
Expand Down
18 changes: 18 additions & 0 deletions lib/rules/role-img-alt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"id": "role-img-alt",
"selector": "[role='img']:not(svg):not(img):not(area):not(input):not(object)",
"tags": [
"cat.text-alternatives",
"wcag2a",
"wcag111",
"section508",
"section508.22.a"
],
"metadata": {
"description": "Ensures [role='img'] elements have alternate text",
"help": "[role='img'] elements have an alternative text"
},
"all": [],
"any": ["aria-label", "aria-labelledby", "non-empty-title"],
"none": []
}
5 changes: 1 addition & 4 deletions test/integration/rules/image-alt/image-alt.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,4 @@
<img src="img.jpg" id="pass6" role="presentation" />
<img src="img.jpg" id="pass7" role="none" />
<img src="img.jpg" id="pass8" aria-labelledby="ninjamonkeys" />
<div role="img" alt="blah" id="violation6"></div>
<img src="img.jpg" id="violation7" alt=" " />
<div role="img" aria-label="blah" id="pass9"></div>
<svg role="img" id="ignore1"><title>SVG Title</title></svg>
<img src="img.jpg" id="violation6" alt=" " />
6 changes: 2 additions & 4 deletions test/integration/rules/image-alt/image-alt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
["#violation3"],
["#violation4"],
["#violation5"],
["#violation6"],
["#violation7"]
["#violation6"]
],
"passes": [
["#pass1"],
Expand All @@ -18,7 +17,6 @@
["#pass5"],
["#pass6"],
["#pass7"],
["#pass8"],
["#pass9"]
["#pass8"]
]
}
13 changes: 13 additions & 0 deletions test/integration/rules/role-img-alt/role-img-alt.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<div id="match">Bananas</div>
<div id="hidden-match" style="display:none">Banana bombs</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to put role="img" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's purely for testing aria-labelledby, it's a pattern used in other alt tests.


<div role="img" aria-label="blah" id="pass1"></div>
<div role="img" aria-labelledby="match" id="pass2"></div>
<div role="img" aria-labelledby="hidden-match" id="pass3"></div>
<div role="img" title="title" id="pass4"></div>

<div role="img" id="violation1"></div>
<div role="img" aria-label="" id="violation2"></div>
<div role="img" alt="blah" id="violation3"></div>
<div role="img" aria-labelledby="no-match" id="violation4"></div>
<div role="img" title="" id="violation5"></div>
12 changes: 12 additions & 0 deletions test/integration/rules/role-img-alt/role-img-alt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"description": "role-img-alt tests",
"rule": "role-img-alt",
"violations": [
["#violation1"],
["#violation2"],
["#violation3"],
["#violation4"],
["#violation5"]
],
"passes": [["#pass1"], ["#pass2"], ["#pass3"], ["#pass4"]]
}