Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make nullable impact properties have nullable types per API docs #1477

Merged

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Apr 4, 2019

Update axe.d.ts to match API.md in terms of which result impact properties may sometimes be null

Closes issue: #1476

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Stephen

@dbjorge dbjorge requested a review from a team as a code owner April 4, 2019 22:32
@CLAassistant
Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

@stephenmathieson stephenmathieson merged commit efaed91 into dequelabs:develop Apr 5, 2019
@stephenmathieson
Copy link
Member

Thanks!

@dbjorge dbjorge deleted the 1476-optional-impact-typings branch April 5, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants