Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inapplicable results aren't returned #473

Closed
WilcoFiers opened this issue Aug 4, 2017 · 4 comments
Closed

inapplicable results aren't returned #473

WilcoFiers opened this issue Aug 4, 2017 · 4 comments
Labels
core Issues in the core code (lib/core)

Comments

@WilcoFiers
Copy link
Contributor

In the result, the inapplicable array is always empty.
@marcysutton marcysutton added the core Issues in the core code (lib/core) label Sep 28, 2017
@robdodson robdodson mentioned this issue Sep 29, 2017
Closed
@robdodson robdodson mentioned this issue Oct 9, 2017
Merged
@robdodson
Copy link
Contributor

@WilcoFiers do you happen to know if anyone is working on this? I'd love to roll this into Lighthouse to improve the accuracy of our scores.

@WilcoFiers
Copy link
Contributor Author

@robdodson I don't think so. You're welcome to it if you've got the time. If you get it done by the end of next week we can release it as part of 2.6.0. Otherwise it might have to wait until 3.0 in February.

@robdodson
Copy link
Contributor

ok i'll take a shot at it. I may be bugging you and marcy on Slack a bit 😸

robdodson added a commit to robdodson/axe-core that referenced this issue Dec 12, 2017
@robdodson
fix: Return inapplicable results (dequelabs#473).
b28aef3
WilcoFiers pushed a commit that referenced this issue Dec 13, 2017
@robdodson @WilcoFiers
fix: Return inapplicable results (#473).
c9caeff 
* fix: Return inapplicable results (#473).

* fix: Tweak aggregateRule to always return inapplicable if nodes are empty. Add test.

* fix: Remove .only

* fix: Rename aggregateRule() to aggregateNodeResults()
WilcoFiers pushed a commit that referenced this issue Dec 13, 2017
@robdodson @WilcoFiers
fix: Return inapplicable results (#473).
0a2a5cc 
* fix: Return inapplicable results (#473).

* fix: Tweak aggregateRule to always return inapplicable if nodes are empty. Add test.

* fix: Remove .only

* fix: Rename aggregateRule() to aggregateNodeResults()
@dependencies dependencies bot mentioned this issue Dec 19, 2017
Merged
@marcysutton
Copy link
Contributor

Rob's awesome fix got merged, so I believe we can close the issue. Please let us know if we need to reopen.

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
@michael-siek
fix(playwright): use axe-core source without require.resolve() (deque…
62d9240 
…labs#473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues in the core code (lib/core)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@WilcoFiers @marcysutton @robdodson and others