Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color-contrast does not support mix-blend-mode: color | luminosity | saturation #4170

Closed
straker opened this issue Sep 22, 2023 · 6 comments · Fixed by #4365
Closed

color-contrast does not support mix-blend-mode: color | luminosity | saturation #4170

straker opened this issue Sep 22, 2023 · 6 comments · Fixed by #4365
Assignees
@straker
Labels
color contrast Color contrast issues fix Bug fixes
Milestone
Axe-core 4.9.0

Comments

@straker
Copy link
Contributor

straker commented Sep 22, 2023 •
edited
Loading

The following HTML produces an error of "blendFunctions[blendMode] is not a function". Looks like we need to add the color blend mode to our list of blend functions. We also need to add luminosity and saturation.

<div style="mix-blend-mode: color;">Errors</div>
@straker straker added color contrast Color contrast issues bug labels Sep 22, 2023
@adamraine adamraine mentioned this issue Sep 28, 2023
Closed
2 tasks
@straker straker added fix Bug fixes and removed bug labels Oct 31, 2023
@kundan8239
Copy link

Is this fix available on npm ?

@straker straker added this to the Axe-core 4.9 milestone Nov 20, 2023
@straker
Copy link
Contributor Author

straker commented Nov 20, 2023

@kundan8239 This hasn't been fixed yet. We hope to get it into the 4.9 release, but we don't have it groomed yet nor a schedule for when it will be released.

@Alpdog14
Copy link

Alpdog14 commented Mar 7, 2024

This is still causing issues on my corporate website, when will this be resolved on Lighthouse tool? or when will it be updated? Like a date?

@straker
Copy link
Contributor Author

straker commented Mar 7, 2024

@Alpdog14 We are planning the 4.9 release so can make sure to include this.

@straker straker modified the milestones: Axe-core 4.10, Axe-core 4.9.0 Mar 7, 2024
@Alpdog14
Copy link

Alpdog14 commented Mar 7, 2024

@straker , do u know when Google Chrome will be releasing that 4.9 version of Axe-Core in its brower? because it is still showing a ! for accessibility when I run it

@straker
Copy link
Contributor Author

straker commented Mar 7, 2024

I do not. Once we release 4.9 it'll still take awhile for Google to update Lighthouse and their products to ingest the changes.

@straker straker mentioned this issue Mar 7, 2024
Merged
@straker straker self-assigned this Mar 7, 2024
straker added a commit that referenced this issue Mar 13, 2024
@straker
fix(color-contrast): support color blend modes hue, saturation, color…
7ae4761 
…, luminosity (#4365)

Decided to add functions to the `Color` class itself to handle adding,
dividing, and multiplying a color by a value. Made it cleaner than
trying to do that in functions of the flatten color code.

Also refactored the code a bit to put the default export at the top.

Closes: #4170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

Labels
color contrast Color contrast issues fix Bug fixes
Projects
None yet
Milestone
Axe-core 4.9.0
Development

Successfully merging a pull request may close this issue.

fix(color-contrast): support color blend modes hue, saturation, color, luminosity dequelabs/axe-core
3 participants
@Alpdog14 @straker @kundan8239