fix(axe.d.ts): allow Node for include/exclude object

[straker]

These all work correctly:

const div = document.querySelector('div');
await axe.run({ include: div });
await axe.run({ include: [div] });
await axe.run({ include: doument.querySelectorAll('div') });

Closes issue: #3334

[WilcoFiers]

I'm a little surprised this works, since QSA returns a NodeList rather than an array. Should we explicitly mention NodeList?

[straker]

Looked into this. It looks like it doesn't matter what exactly is passed in for the include/exclude object so long as it is array-like. Once we get the context object we immediately call parseSelectorArray, which loops over the context include/object object using a for loop that looks at the length of the object to resolve them as VirtualNodes.

I'm OK if we don't mention this particular case for now. We should loop back to this and determine if it's something we explicitly want to support, and if so add an official test to our code to ensure it continues to work.

[stephenmathieson]

In that case, wouldn't ArrayLike<Node> be the best option?

[straker]

If we decide to officially support it then ya, that should be the correct type. For now I'm going to change the ts test to not use querySelectorAll and will update it back in another pr if we decide to support it (along with the proper test and doc updates).

[stephenmathieson]

NBD, but it sounds like this should be:

Suggested change

	include?: Node | BaseSelector | Array<Node | BaseSelector | BaseSelector[]>;
	exclude?: Node | BaseSelector | Array<Node | BaseSelector | BaseSelector[]>;
	include?: Node | BaseSelector | ArrayLike<Node> | Array<BaseSelector | BaseSelector[]>;
	exclude?: Node | BaseSelector | ArrayLike<Node> | Array<BaseSelector | BaseSelector[]>;