Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typing for include-exclude object #3334

Closed
matyasf opened this issue Jan 3, 2022 · 1 comment
Closed

Wrong typing for include-exclude object #3334

matyasf opened this issue Jan 3, 2022 · 1 comment
Labels
fix Bug fixes pr A pr has been created for the issue typescript TypeScript issues

Comments

@matyasf
Copy link

matyasf commented Jan 3, 2022

Product: axe-core, issue type: Typing bug

Expectation: include-exclude object accepts DOM node instances
Actual: it only accepts strings

See the docs for this: https://github.com/dequelabs/axe-core/blob/develop/doc/API.md#include-exclude-object a DOM node is a valid value.
Compare this to its typing: https://github.com/dequelabs/axe-core/blob/develop/axe.d.ts#L54


axe-core version: 4.3.5
@straker
Copy link
Contributor

straker commented Jan 7, 2022

Thanks for the issue. Have a pr to fix this.

@straker straker added fix Bug fixes typescript TypeScript issues pr A pr has been created for the issue labels Jan 7, 2022
@straker straker mentioned this issue Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Bug fixes pr A pr has been created for the issue typescript TypeScript issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @straker @matyasf