fix(aria--allowed-role): Allow iframe role=none

dequelabs · Feb 11, 2019 · a4fa44d · a4fa44d
1 parent c60a7d1
commit a4fa44d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/lib/commons/aria/index.js b/lib/commons/aria/index.js
@@ -522,7 +522,7 @@ lookupTable.role = {
 		context: null,
 		implicit: ['body'],
 		unsupported: false,
-		allowedElements: ['article', 'embed', 'iframe', 'section', 'svg', 'object']
+		allowedElements: ['article', 'embed', 'iframe', 'object', 'section', 'svg']
 	},
 	'doc-abstract': {
 		type: 'section',
@@ -1407,9 +1407,11 @@ lookupTable.role = {
 					'h5',
 					'h6',
 					'header',
+					'iframe',
 					'li',
+					'ol',
 					'section',
-					'ol'
+					'ul'
 				]
 			},
 			{
@@ -1491,9 +1493,11 @@ lookupTable.role = {
 					'h5',
 					'h6',
 					'header',
+					'iframe',
 					'li',
+					'ol',
 					'section',
-					'ol'
+					'ul'
 				]
 			},
 			{

diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.html b/test/integration/rules/aria-allowed-role/aria-allowed-role.html
@@ -41,6 +41,8 @@ <h1 id='pass-h1-valid-role' role='none'></h1>
 <aside id="pass-aside-role-region" role="region"></aside>
 <form action="" id='pass-form-role-search' role="search"></form>
 <ul><li id="pass-li-role-sep" role="separator"></li></ul>
+<iframe src="dummy.html" role="presentation" id="pass-iframe-presentation"></iframe>
+<iframe src="dummy.html" role="none" id="pass-iframe-none"></iframe>
 <my-custom-element id="pass-custom-element-any-role" role='navigation'></my-custom-element>
 <dd id='fail-dd-no-role' role='link'></dd>
 <dt id='fail-dt-no-role' role='banner'></dt>

diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.json b/test/integration/rules/aria-allowed-role/aria-allowed-role.json
@@ -45,6 +45,8 @@
 		["#pass-aside-role-region"],
 		["#pass-form-role-search"],
 		["#pass-li-role-sep"],
+		["#pass-iframe-presentation"],
+		["#pass-iframe-none"],
 		["#pass-custom-element-any-role"]
 	],
 	"violations": [

diff --git a/test/integration/rules/aria-allowed-role/dummy.html b/test/integration/rules/aria-allowed-role/dummy.html