-
Notifications
You must be signed in to change notification settings - Fork 765
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(closest): VirtualNode implementation of Element.closest. Depreca…
…te commons.dom.findUp and commons.dom.findUpVirtual (#2139) * feat(closest): VirtualNode implementation of Element.closest. Deprecate commons.dom.findUp and commons.dom.findUpVirtual * add shadow support
- Loading branch information
Showing
3 changed files
with
81 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** | ||
* closest implementation that operates on a VirtualNode | ||
* | ||
* @method closest | ||
* @memberof axe.utils | ||
* @param {VirtualNode} vNode VirtualNode to match | ||
* @param {String} selector CSS selector string | ||
* @return {Boolean} | ||
*/ | ||
axe.utils.closest = function closest(vNode, selector) { | ||
while (vNode) { | ||
if (axe.utils.matches(vNode, selector)) { | ||
return vNode; | ||
} | ||
|
||
vNode = vNode.parent; | ||
} | ||
|
||
return null; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
describe('utils.closest', function() { | ||
var closest = axe.utils.closest; | ||
var fixture = document.querySelector('#fixture'); | ||
var queryFixture = axe.testUtils.queryFixture; | ||
var shadowSupported = axe.testUtils.shadowSupport.v1; | ||
|
||
afterEach(function() { | ||
fixture.innerHTML = ''; | ||
}); | ||
|
||
it('should find the current node', function() { | ||
var virtualNode = queryFixture( | ||
'<div id="parent"><div id="target">foo</div></div>' | ||
); | ||
var closestNode = closest(virtualNode, 'div'); | ||
assert.equal(closestNode, virtualNode); | ||
}); | ||
|
||
it('should find a parent node', function() { | ||
var virtualNode = queryFixture( | ||
'<div id="parent"><span id="target">foo</span></div>' | ||
); | ||
var closestNode = closest(virtualNode, 'div'); | ||
var parent = fixture.querySelector('#parent'); | ||
assert.equal(closestNode, axe.utils.getNodeFromTree(parent)); | ||
}); | ||
|
||
it('should find an ancestor node', function() { | ||
var virtualNode = queryFixture( | ||
'<div id="parent"><span><span><span><span id="target">foo</span></span></span></div>' | ||
); | ||
var closestNode = closest(virtualNode, 'div'); | ||
var parent = fixture.querySelector('#parent'); | ||
assert.equal(closestNode, axe.utils.getNodeFromTree(parent)); | ||
}); | ||
|
||
it('should return null if no ancestor is found', function() { | ||
var virtualNode = queryFixture( | ||
'<div id="parent"><div id="target">foo</div></div>' | ||
); | ||
var closestNode = closest(virtualNode, 'h1'); | ||
assert.isNull(closestNode); | ||
}); | ||
|
||
(shadowSupported ? it : xit)('should support shadow dom', function() { | ||
fixture.innerHTML = '<div id="parent"></div>'; | ||
|
||
var root = fixture.firstChild.attachShadow({ mode: 'open' }); | ||
var slotted = document.createElement('span'); | ||
slotted.innerHTML = '<span id="target">foo</span>'; | ||
root.appendChild(slotted); | ||
axe.utils.getFlattenedTree(fixture.firstChild); | ||
|
||
var virtualNode = axe.utils.getNodeFromTree(slotted.firstChild); | ||
var parent = fixture.querySelector('#parent'); | ||
var closestNode = closest(virtualNode, 'div'); | ||
assert.equal(closestNode, axe.utils.getNodeFromTree(parent)); | ||
}); | ||
}); |