Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fixes #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Additional fixes #2

wants to merge 2 commits into from

Conversation

grahambates
Copy link
Contributor

I found and fixed a couple more issues:

  • MOVEP:
    • Operand type should be ARDISP, not ARIND
    • Bitmask for DR -> ARDISP was wrong
  • Bit operations:
    • The size qualifier for BTST, BCHG etc is based on the type of the destination operand, not the source as currently implemented. It should be long for DR and byte for all others types.

@grahambates
Fix movep
b2f644c 
bitmask and operand types were wrong
@grahambates
Bit operation sizes
548436f 
The size qualifier for `BTST`, `BCHG` etc is based on the type of the
destination operand, not the source as currently implemented. It should
be long for `DR` and byte for all others types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@grahambates