Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(markdown): add marksman lsp #4565

Merged
merged 7 commits into from
Aug 1, 2023
Merged

feat(markdown): add marksman lsp #4565

merged 7 commits into from
Aug 1, 2023

Conversation

pbnj
Copy link
Contributor

@pbnj pbnj commented Jul 28, 2023 •
edited
Loading

Todo:

  • add docs
  • add tests

@pbnj
Copy link
Contributor Author

pbnj commented Jul 29, 2023

@hsanson - appreciate a review :)

thank you!

w0rp
w0rp approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you did everything right. 👍

@w0rp w0rp merged commit 18cd44c into dense-analysis:master Aug 1, 2023
7 checks passed
@w0rp
Copy link
Member

w0rp commented Aug 1, 2023

Cheers! 🍻

mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
@pbnj @mnikulin
feat(markdown): add marksman lsp (dense-analysis#4565)
739e50d 
* feat(markdown): add marksman lsp
* docs: add marksman docs
* test(markdown): add marksman test

Co-authored-by: Peter Benjamin <peter.benjamin@peter.benjamin-FVFHP2WSQ05Q>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pbnj @w0rp