test(utils): increase test coverage #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mbhrznr, do you mind pausing work on this one? I realise that quite a few functions in db do too much. I want to refactor/simplify. |
sure thing, just give me a ping whenever you're ready! |
|
If you'd like to do everything else within utils, except for |
mbhrznr
force-pushed
the
test/add-code-coverage-to-utils
branch
from
d64017f
to
2514124
Compare
iuioiua
changed the title
iuioiua
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #267
improves overall coverage for
utilsby tackling the uncovered snippets as reported here.as requested by @iuioiua this pr explicitly excludes
utils/db.tsuntil the refactoring has been resolved.as a drive-by
timeAgohas been refactored to make use ofstd/datetime/difference.ts.