feat: initial cross-platform shebang support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 26, 2024
| @@ -684,7 +689,7 @@ fn execute_command_args( | |||
| } | |||
| } | |||
|
|
|||
| async fn evaluate_args( | |||
| pub(crate) async fn evaluate_args( | |||
There was a problem hiding this comment.
I'll land a follow-up PR after this one to clean this up.
bartlomieju
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Can you please open a PR to https://github.com/denoland/deno-docs that explains this in a few sentences?
|
Will do when merging to CLI. |
This was referenced Mar 27, 2024
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Mar 27, 2024
Adds cross-platform shebang support (supports using shebangs in `deno task` on Windows) denoland/deno_task_shell#113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23