Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install instructions for Arch Linux #161

Merged
merged 1 commit into from
May 14, 2021
Merged

Update install instructions for Arch Linux #161

merged 1 commit into from
May 14, 2021

Conversation

eastack
Copy link
Contributor

@eastack eastack commented Sep 19, 2020

No description provided.

Copy link

@solson solson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - for anyone unfamiliar, AUR is the Arch User Repository for unofficial packages, while pacman is the official package manager.

@daemon1024
Copy link

daemon1024 commented Oct 20, 2020

@rwrr It seems like the deno package on pacman is on version 1.4.2 and deno-bin on AUR is version 1.4.6. So it would be great if both of these versions are visible in the README.

@MarkTiedemann
Copy link
Contributor

@rwrr It seems like the deno package on pacman is on version 1.4.2 and deno-bin on AUR is version 1.4.6. So it would be great if both of these versions are visible in the README.

I don't think that's a good idea because then the README will have to be repeatedtly updated to show the latest version.

@solson
Copy link

solson commented Oct 20, 2020

@MarkTiedemann That is not true, it just needs to explain both yay -S deno-bin (as before this PR) and pacman -S deno (instead of yay -S deno). The deno docs don't need to mention version numbers at all, it's just that the AUR package deno-bin will tend to be more up to date than the official package deno, and users may prefer either one.

@MarkTiedemann
Copy link
Contributor

MarkTiedemann commented Oct 20, 2020

Oh, I misunderstood. I read @rwrr's comment as saying that both deno versions, pacman 1.4.2 and AUR 1.4.6, should be included in the README. Thanks for clearing this up, @solson!

Yes, I'm fine with both pacman deno and AUR deno-bin being included (as long as no specific version numbers are mentioned).

@Nircek
Copy link

Nircek commented Nov 25, 2020

The month passed, and there is still only an AUR solution in the README.

@UnlimitedCookies
Copy link

UnlimitedCookies commented May 13, 2021

As an archlinux user I can approve the proposed changes. The official repositories are deemed trustworthy and thus should be the ones recommended here. The Arch User Repository package deno-bin has been removed in favor of the new official package deno, because it provides no real benefit in comparison. The only relevant AUR package at this point is deno-git, which downloads and builds directly from the git repo on the user's computer. If you want to mention this package (which is not mandatory imo), a note about it being user-provided content should be included.

@eastack
Copy link
Contributor Author

eastack commented May 14, 2021

Should the AUR installation method be added back? The forked repository under my personal account has been deleted. If I modify the content, should I reopen a pull request?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review. This looks good to me. Thank you for the inputs & advise.

@kt3k kt3k merged commit f029842 into denoland:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants