Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show blank line diagnostic #268

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 8, 2024

swc starting doing EOF errors on the last char instead of last non-whitespace char (which makes sense)

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit aa9eae4 into denoland:main Aug 8, 2024
2 checks passed
@dsherret dsherret deleted the fix_diagnostic_empty_line branch August 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants