Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not panic doing scope analysis before emit #240

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix: do not panic doing scope analysis before emit #240

merged 3 commits into from
Apr 16, 2024

Conversation

dsherret
Copy link
Member

No description provided.

@dsherret dsherret marked this pull request as ready for review April 16, 2024 19:53
marvinhagemeister
marvinhagemeister approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@dsherret dsherret merged commit 4afeaee into denoland:main Apr 16, 2024
2 checks passed
@dsherret dsherret deleted the fix_panic_scope_analysis_before_emit branch April 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsherret @marvinhagemeister