Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(BREAKING): do not emit comments by default #221

Merged
merged 1 commit into from
Mar 13, 2024
Merged

perf(BREAKING): do not emit comments by default #221

merged 1 commit into from
Mar 13, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 12, 2024 •
edited
Loading

I don't think there's any reason for us to emit comments by default.

bartlomieju
bartlomieju approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we get a transform that would drop comments from JS sources but otherwise leave them intact? I think we could save some Kbs if we did that for internal code during snapshotting.

@dsherret dsherret mentioned this pull request Mar 13, 2024
Closed
@dsherret dsherret merged commit 841ba43 into denoland:main Mar 13, 2024
2 checks passed
@dsherret dsherret deleted the perf_do_not_emit_comments_default branch March 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherret @marvinhagemeister @bartlomieju