Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precompile don't escape component text children #213

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

marvinhagemeister
Copy link
Contributor

The JSX precompile transform was a bit overzealous when escaping component children that were text nodes. These must not be pre-escaped and instead must be passed as is to the component, otherwise they will be escaped multiple times.

Fixes denoland/deno#22577

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 2dffa0f into main Feb 26, 2024
2 checks passed
@marvinhagemeister marvinhagemeister deleted the precompile-component-text branch February 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsx precompile: double escape bug
2 participants