fix: non-identifier properties not quoted

[marvinhagemeister]

Ran into a bug where we didn't quote non-identifier object properties like aria-label.

// before
const a = { aria-label: "foo" }

// after
const a = { "aria-label": "foo" }

[dsherret]

I have this function in dprint. Would it be useful to use here? (is_ident_start() and is_ident_part() are helper methods from swc)

use deno_ast::swc::parser::lexer::util::CharExt;

fn is_text_valid_identifier(string_value: &str) -> bool {
  if string_value.is_empty() {
    return false;
  }
  for (i, c) in string_value.chars().enumerate() {
    if (i == 0 && !c.is_ident_start()) || !c.is_ident_part() {
      return false;
    }
  }
  true
}

[dsherret]

My guess is probably not because jsx attribute names are limited in what they can contain?

[marvinhagemeister]

Ohh nice! I was looking for something like is_Ident_start but didn't find it 👍

[dsherret]

LGTM