feat: swc_ecma_parser 0.137.5 #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
We can't upgrade because we're blocked by swc-project/swc#7621 (swc-project/swc#7692). I've been working on #148, but haven't had much time to fix the swc issue. |
|
Oh sorry, I was not aware of that. |
|
It was my bad for not updating the PR with the status. Usually an swc upgrade is a big task because it needs to be tested with all the downstream Deno crates and that often requires a few code changes. In this case, I reverted the PR in swc that was causing some trouble so that we can proceed with the upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Hope it's okay to open a PR like this, since #148 has been open/approved for about a month now, and
0.137.5ofswc_ecma_parserhas been released in the meantime.