fix(cjs): analyze exports for chained assignments in module.exports #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dsherret
requested changes
Jul 20, 2023
src/cjs_parse.rs
Outdated
Comment on lines
166
to
168
| self.in_module_exports = true; | ||
| self.visit_assign_expr(right_assign_expr); | ||
| self.in_module_exports = false; |
There was a problem hiding this comment.
Seems like we can remove this extra state and just do?
Suggested change
| self.in_module_exports = true; | |
| self.visit_assign_expr(right_assign_expr); | |
| self.in_module_exports = false; | |
| self.visit_exports_right_expr(&right_assign_expr.right); |
That seems to pass all the current tests, but is there a scenario where self.in_module_exports is necessary? It would be best to not introduce more state if possible.
There was a problem hiding this comment.
Thanks for your suggestion, indeed in_module_exports is redundant ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related denoland/deno#19865
For the following cjs code:
Currently
exportsis an empty array afteranalyze_cjs(), it should be["a", "b", "c"].