Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing URL.parse types #23893

Merged
merged 1 commit into from
May 19, 2024
Merged

fix: add missing URL.parse types #23893

merged 1 commit into from
May 19, 2024

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented May 19, 2024 •
edited
Loading

nayeemrmn
nayeemrmn approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It's strange that the upstream doesn't accept base: URL for canParse(), seems like an inconsistency on their part.

@nayeemrmn nayeemrmn merged commit 9e89039 into denoland:main May 19, 2024
17 checks passed
@petamoriken petamoriken deleted the fix/url-parse-types branch May 19, 2024 14:58
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@petamoriken @bartlomieju
fix: add missing URL.parse types (#23893)
0269969
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@petamoriken @bartlomieju
fix: add missing URL.parse types (#23893)
55c8c85
@nayeemrmn nayeemrmn mentioned this pull request Jun 14, 2024
Closed
@petamoriken petamoriken mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeemrmn nayeemrmn nayeemrmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL.parse() is missing from lib.dom.d.ts
2 participants
@petamoriken @nayeemrmn