Added new color for visible (but unfocused) workspace and its config value #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denesb
requested changes
Aug 1, 2017
| add_color_picker(config, dialog_vbox, "Focused Workspace Color:", config->focused_color, focused_color_changed); | ||
| add_color_picker(config, dialog_vbox, "Urgent Workspace Color:", config->urgent_color, urgent_color_changed); | ||
| add_color_picker(config, dialog_vbox, "Unfocused Visible Workspace Color:", config->visible_color, visible_color_changed); | ||
| add_color_picker(config, dialog_vbox, "Binding Mode Color:", config->mode_color, mode_color_changed); |
There was a problem hiding this comment.
I don't understand. Are the add_color_picker's indented 4 more spaces on purpose? I put them on the same level as the surrounding elements.
There was a problem hiding this comment.
Oh wait, you are right. The previous indentation was wrong. Sorry about that.
panel-plugin/i3w-config.c
Outdated
| GdkColor color; | ||
| gtk_color_button_get_color(GTK_COLOR_BUTTON(button), &color); | ||
| config->visible_color = serialize_gdkcolor(&color); | ||
| } |
denesb
approved these changes
Aug 1, 2017
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we mentioned in #49, I implemented the new color in the configuration.
About the naming, inside the code I have chosen to call this new color "visible", since that is the naming used by i3ipc-glib. At the config UI I have called it "Unfocused Visible Workspace Color", but feel free to suggest any other name that suits this better.
Also, I thought that the ternary comparison to decide the color would get a bit too big now that there are 4 different colors for workspace labels, so I replaced that by an if-else chain which is more readable IMO.
The rest of the changes are pretty self-explanatory