Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes if a not-focused workspace is emptied #3

Closed
xuhdev opened this issue Dec 8, 2014 · 3 comments
Closed

Crashes if a not-focused workspace is emptied #3

xuhdev opened this issue Dec 8, 2014 · 3 comments
Labels

Comments

@xuhdev
Copy link
Contributor

xuhdev commented Dec 8, 2014

On this line, it assumes the emptied workspace is always the last focused one. It's not necessarily true: a window can be killed in another workspace to empty it, e.g. you can use the Pidgin tray icon to terminate pidgin in a different workspace.

@denesb
Copy link
Owner

denesb commented Dec 9, 2014

I was able to trigger multiple crashes yesterday while "stresstesting" the
plugin. It always crashed when a workspace was emptied, so this could be
the problem.
I must find another way then to tell which workspace has to be destroyed.

On Mon, Dec 8, 2014 at 11:11 PM, Hong Xu notifications@github.com wrote:

On this line
https://github.com/denesb/xfce4-i3-workspaces-plugin/blob/master/panel-plugin/i3wm-delegate.c#L245,
it assumes the emptied workspace is always the last focused one. It's not
necessarily true: a window can be killed in another workspace to empty it,
e.g. you can use the Pidgin tray icon to terminate pidgin in a different
workspace.


Reply to this email directly or view it on GitHub
#3.

Dénes Botond
dns.botond@gmail.com

@xuhdev
Copy link
Contributor Author

xuhdev commented Dec 10, 2014

I opened a i3 ticket to solve this

@denesb denesb added the bug label Dec 10, 2014
@denesb
Copy link
Owner

denesb commented Dec 21, 2014

I solved this in 1.0.0 by re-requesting the workspace list on empty/init events.

@denesb denesb closed this as completed Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants