-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core to 1.147 #4194
Update core to 1.147 #4194
Conversation
According to CHANGELOG core does not support it any more since 1.143 "Remove old iroh 0.4 and support for old `DCBACKUP` QR codes."
Seems we have to adapt settings first. At least step 1 from #4124 |
Step 1 of #4124
Step 1 of #4124 is included here now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i did a quick functionality check and could manage to connect via ss://YWVzLTEyOC1nY206c2hhZG93c29ja3M=@156.146.62.163:443#Switzerland%20#1270%20/%20OutlineKeys.com
- nice!
for the UI: as this is subject to change anyways and will do to a dedicated dialog, it is good enough for now.
for the strings: they are available already translated, no need to add them to "untranslated".
for the "placeholder", i'd strike that for now, that seems more confusing and cluttering than helpful - ppl will have a proxy URL from some sources and needs and will paste them here - and not the other way round. also, already now it is incomplete as ss
is missing.
if we think, a placeholder is useful, let's start with that on android, where we move ahead with proxy settings and collect more experiences.
i cannot say much to the rest of the code
where can I check what is already translated? How do we import the new strings then? Otherwise the preview would miss the labels... |
I agree - at least as long the placeholder has the same styling than the entered text |
note that there is 1.147.1 meanwhile, 1.147.0 contained a bug that resulted in some incompatibilities with existing releases, see deltachat/deltachat-core-rust#6038 |
No description provided.