Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new proxy_enable and proxy_url settings #4124

Open
3 of 8 tasks
link2xt opened this issue Sep 12, 2024 · 2 comments
Open
3 of 8 tasks

Use new proxy_enable and proxy_url settings #4124

link2xt opened this issue Sep 12, 2024 · 2 comments
Labels
blocker This issue is blocking a new release new-core involves or requires an dc-node/core update

Comments

@link2xt
Copy link
Collaborator

link2xt commented Sep 12, 2024 •
edited by nicodh
Loading

With core release 1.143.0 old socks5_* settings are deprecated and proxy_* should be used instead.

This should be done when done is updated from 1.142.x.

deltachat/deltachat-android#3292 gives an idea how the screen looks like in Android

Step 1

  • Change Setting Types: socks5_enabled, socks5_host, socks5_port, socks5_user, socks5_password => proxy_enabled, proxy_url
  • Adapt form: One text field for one proxy_url (placeholder: "Enter proxy URL here"
  • UI: Show explaining text: "Supported proxy types: HTTP(S), SOCKS5 and Shadowsocks"

Step 2 (in separate PR)

  • UI: add client side validation
  • UI: Show connectivity status & proxy type
  • UI: enable multiple proxy url entries
  • if a proxy is clicked/selected/added, enable "use proxy" toggle

Step 3 (in separate PR)

new-proxy-settings

Sharing is probably not necessary on desktop
@Simon-Laux Simon-Laux added blocker This issue is blocking a new release new-core involves or requires an dc-node/core update labels Oct 2, 2024
@nicodh nicodh mentioned this issue Oct 9, 2024
Merged
@nicodh
Copy link
Contributor

nicodh commented Oct 11, 2024

@link2xt : do we not support username & password for proxies anymore or can it be entered in the form username:password@some.host:8080

nicodh added a commit that referenced this issue Oct 11, 2024
@nicodh
Use new proxy settings
3ca0b54 
Step 1 of #4124
@link2xt
Copy link
Collaborator Author

link2xt commented Oct 11, 2024 •
edited
Loading

Username and password are supported in the form of socks5://username:password@host:port.
Username and password should be URL-encoded.

nicodh added a commit that referenced this issue Oct 15, 2024
@nicodh
Update core to 1.147 (#4194)
d6a30a9 
* Update core to 1.147.1

* Remove "backup" from ALLOWED_QR_CODES_ON_WELCOME_SCREEN

According to CHANGELOG core does not support it any more since 1.143

"Remove old iroh 0.4 and support for old `DCBACKUP` QR codes."

* Use new proxy settings

Step 1 of #4124

* Update languages and CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker This issue is blocking a new release new-core involves or requires an dc-node/core update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicodh @link2xt @Simon-Laux