Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DELTA] Support TimestampNTZ DataType #1626

Closed
wants to merge 1 commit into from

Conversation

rahulsmahadev
Copy link
Collaborator

@rahulsmahadev rahulsmahadev commented Mar 1, 2023

Closes #1627

  • This change adds support to TimestampNTZ type in Delta
  • Previously this type was not supported in Spark and Spark 3.3 added support for this
  • To prevent(gate) older writers/readers from reading to this column we need a protocol(feature) bump that does the gating
  • This PR creates a new TableFeature TimestampNTZ feature that is a ReaderWriter feature
  • This is how to feature is automatically enabled
    <style type="text/css"></style>
Scenario Previously With this change
User creates a new table with timestamp NTZ column AnalysisException saying type not supported Protocol upgraded to feature vector protocol and TimestampNTZ Feature automatically enabled and DDL successful
User adds a new column of type TimestampNTZ on legacy protocol version AnalysisException saying type not supported Error thrown asking user to enable table feature for TimestampNTZ
User adds a new column of type TimestampNTZ on table with TimestampNTZFeature enabled on the table AnalysisException saying type not supported User DDL completes successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for Timestamp without Time Zone DataType
1 participant