Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose optimize in Python bindings #622

Closed
wjones127 opened this issue Jun 4, 2022 · 6 comments
Closed

Expose optimize in Python bindings #622

wjones127 opened this issue Jun 4, 2022 · 6 comments
Labels
binding/python Issues for the Python package enhancement New feature or request

Comments

@wjones127
Copy link
Collaborator

Description

#607 added optimize implementation using datafusion in rust. If we enable the datafusion option in the Python package, we can expose this in Python. We'll likely want this feature anyways to support writer protocol version 2 (see #592).

Use Case

Related Issue(s)
@wjones127 wjones127 added enhancement New feature or request binding/python Issues for the Python package labels Jun 4, 2022
@wjones127 wjones127 mentioned this issue Jun 4, 2022
Closed
@roeap roeap mentioned this issue Jun 9, 2022
Merged
@a-m-w
Copy link

a-m-w commented Apr 11, 2023

Is there an approximate timeline when optimization will be supported via Python? Thanks in advance!

@wjones127
Copy link
Collaborator Author

I don't believe anyone has volunteered to work on this yet, so no timeline for now. PRs for this are welcome though! 😄

@loleek
Copy link
Contributor

loleek commented Apr 26, 2023

Maybe I can contribute this. I've already implement it today but without doc and unit-tests.This is my first PR, it maybe take sometime.

@roeap
Copy link
Collaborator

roeap commented Apr 26, 2023 •
edited
Loading

@loleek - that would be awesome!

We are always happy to help you along with reviews and guidance if needed. Feel free to open a draft PR in case you want to discuss.

@loleek loleek mentioned this issue Apr 27, 2023
Merged
wjones127 pushed a commit that referenced this issue May 4, 2023
@loleek
feat: add optimize command in python binding (#1313)
fdb5e7b 
# Description
This is a implementation of the Optimize Command for python binding.

# Related Issue(s)
#622

---------

Co-authored-by: dengkai02 <dengkai02@appledeMacBook-Pro-3.local>
@ion-elgreco
Copy link
Collaborator

@wjones127 this can be closed now, right?

@wjones127
Copy link
Collaborator Author

Yes, thanks for reminding me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/python Issues for the Python package enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wjones127 @loleek @ion-elgreco @roeap @a-m-w