find_module:fix a mistake for kernel with modules uncompressed #442
Conversation
|
I guess you didn't test this merge request at all, right? You have an extra " |
|
It doesn't hurt to add Anyway, please fix the command and we can merge. Thanks. |
dkms.in
Outdated
| @@ -228,7 +228,7 @@ find_module() | |||
| { | |||
| # tree = $1 | |||
| # module = $2 | |||
| find "$1" -name "$2$module_uncompressed_suffix" -o -name "$2$module_suffix" -type f | |||
| find "$1" -name "$2$module_uncompressed_suffix" -type -f -o -name "$2$module_suffix" -type f | |||
There was a problem hiding this comment.
Remove the first dash as -type f.
There was a problem hiding this comment.
Done.I also corrected the commit information.
WizardHowlhaha
force-pushed
the
master
branch
from
5bf360e
to
0384051
Compare
My mistake,I was too careless. Thanks for pointing it out,I've already made the changes. |
Thanks for your help, I've already fix the command. |
WizardHowlhaha
force-pushed
the
master
branch
3 times, most recently
from
fd7b339
to
1cfca90
Compare
For kernel with modules uncompressed,dkms find_module()'s command: find "$1" -name "$2$module_uncompressed_suffix" -o -name "$2$module_suffix" -type f actually turns out to be: `find /lib/modules/[kerv] -name [module_name].ko -o -name [module_name].ko -type f` the "-type f" is used to include only for regular file, but with the command above, it only takes effect for the lastest "-name" match,and will get the symbolic files (are usually the symbolic files for weak_modules in /lib/*/weak-updates directory) by mistake. For kernel with modules compressed the command turns out to be like: `find /lib/modules/[kerv] -name [module_name].ko -o -name [module_name].ko.xz -type f` All the modules are with suffix ".xz",the first "-name" match actually do nothing so it's get nothing wrong. Fix it by adding "-type f" param after each "-name" option.
WizardHowlhaha
force-pushed
the
master
branch
from
1cfca90
to
6ad37dc
Compare
For kernel with modules uncompressed,dkms find_module()'s command: find "$1" -name "$2$module_uncompressed_suffix" -o -name "$2$module_suffix" -type f actually turns out to be:
find /lib/modules/[kerv] -name [module_name].ko -o -name [module_name].ko -type -fthe "type -f" is used to include only for regular file, but with the command above, it only takes effect for the lastest "-name" match,and will get the symbolic files (are usually the symbolic files for weak_modules in /lib/*/weak-updates directory) by mistake.
For kernel with modules compressed the command turns out to be like:
find /lib/modules/[kerv] -name [module_name].ko -o -name [module_name].ko.xz -type -fAll the modules are with suffix ".xz",the first "-name" match actually do nothing so it's get nothing wrong.Fix it by adding "-type -f" param after each "-name" option.