Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/node-local-dns]: add option to set customUpstreamsvc #572

Merged
merged 2 commits into from
Apr 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/node-local-dns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: node-local-dns
version: 2.0.6
version: 2.0.7
appVersion: 1.22.23
maintainers:
- name: gabrieladt
Expand Down
3 changes: 2 additions & 1 deletion stable/node-local-dns/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-local-dns

![Version: 2.0.6](https://img.shields.io/badge/Version-2.0.6-informational?style=flat-square) ![AppVersion: 1.22.23](https://img.shields.io/badge/AppVersion-1.22.23-informational?style=flat-square)
![Version: 2.0.7](https://img.shields.io/badge/Version-2.0.7-informational?style=flat-square) ![AppVersion: 1.22.23](https://img.shields.io/badge/AppVersion-1.22.23-informational?style=flat-square)

A chart to install node-local-dns.

Expand Down Expand Up @@ -52,6 +52,7 @@ helm install my-release deliveryhero/node-local-dns -f values.yaml
| config.bindIp | bool | `false` | |
| config.commProtocol | string | `"force_tcp"` | |
| config.customConfig | string | `""` | |
| config.customUpstreamsvc | string | `""` | |
| config.dnsDomain | string | `"cluster.local"` | |
| config.dnsServer | string | `"172.20.0.10"` | |
| config.healthPort | int | `8080` | |
Expand Down
4 changes: 4 additions & 0 deletions stable/node-local-dns/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ spec:
- "-conf"
- "/etc/Corefile"
- "-upstreamsvc"
{{- if .Values.config.customUpstreamsvc }}
- "{{ .Values.config.customUpstreamsvc }}"
{{- else }}
- "{{ include "node-local-dns.fullname" . }}-upstream"
{{- end }}
- "-skipteardown={{ .Values.config.skipTeardown }}"
- "-setupinterface={{ .Values.config.setupInterface }}"
- "-setupiptables={{ .Values.config.setupIptables }}"
Expand Down
2 changes: 2 additions & 0 deletions stable/node-local-dns/templates/service-upstream.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if not .Values.config.customUpstreamsvc -}}
apiVersion: v1
kind: Service
metadata:
Expand All @@ -17,3 +18,4 @@ spec:
targetPort: 53
selector:
k8s-app: kube-dns
{{- end -}}
3 changes: 3 additions & 0 deletions stable/node-local-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ config:
# Virtual IP to be used by ipvs mode, to be used as --cluster-dns, must not collide.
localDns: "169.254.20.25"

# Use a custom upstreamsvc for -upstreamsvc
customUpstreamsvc: ""

# If true, it will bind 0.0.0.0, otherwise dnsServer and localDns will be used. https://github.com/bottlerocket-os/bottlerocket/issues/3711#issuecomment-1907087528
bindIp: false

Expand Down
Loading