Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns]: add option to set customUpstreamsvc #572

Merged
merged 2 commits into from
Apr 7, 2024
Merged

[stable/node-local-dns]: add option to set customUpstreamsvc #572

merged 2 commits into from
Apr 7, 2024

Conversation

stxm
Copy link
Contributor

@stxm stxm commented Apr 3, 2024 •
edited
Loading

Description

add option the set a custom Upstreamsvc
if the custom upstreamsvc is set the upstream service is not created

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@stxm stxm requested a review from a team as a code owner April 3, 2024 19:33
@stxm
Copy link
Contributor Author

stxm commented Apr 3, 2024

fixed a check

max-rocket-internet
max-rocket-internet approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, like it, thanks @stxm 💚

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) April 7, 2024 22:34
@max-rocket-internet max-rocket-internet merged commit 19e7766 into deliveryhero:master Apr 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stxm @max-rocket-internet