Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Love for remote debugging #406

Merged
merged 27 commits into from
Jan 25, 2018
Merged

Love for remote debugging #406

merged 27 commits into from
Jan 25, 2018

Commits on Jan 13, 2018

  1. Extract client to a separate class

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    ffb1648 View commit details
    Browse the repository at this point in the history

  2. Document control port

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    a367155 View commit details
    Browse the repository at this point in the history

  3. Consistent port setting

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    944e07b View commit details
    Browse the repository at this point in the history

  4. Improve docs

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    2711a69 View commit details
    Browse the repository at this point in the history

  5. Normalize argument name

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    74b8488 View commit details
    Browse the repository at this point in the history

  6. Only need mutexes if waiting for clients

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    4a5f884 View commit details
    Browse the repository at this point in the history

  7. Don't care about start_control return value 

    The port is accessible via `actual_control_port` anyways.
    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    a835a22 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary line

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    3751bda View commit details
    Browse the repository at this point in the history

  9. Extract server to a separate class

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    2b08eee View commit details
    Browse the repository at this point in the history

  10. Extract a method

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    15befcb View commit details
    Browse the repository at this point in the history

  11. Fix remote debugging regression 

    In the case of remote debugging, we don't want to close the interface
after each repl. Introduced by e42078f.
Adding initial tests for remote debugging.
    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    e7279ed View commit details
    Browse the repository at this point in the history

  12. Don't crash when client disconnects

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    7497035 View commit details
    Browse the repository at this point in the history

  13. Clarify a comment

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    cfc5cff View commit details
    Browse the repository at this point in the history

  14. Disable all rubocop metrics

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    3e8ad87 View commit details
    Browse the repository at this point in the history

  15. Shortcut for starting a remote debugger

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    f75e7ac View commit details
    Browse the repository at this point in the history

  16. Test server & control threads are ignored

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    ceebb4d View commit details
    Browse the repository at this point in the history

  17. Make sure byebug is started before interrupting it 

    Since, for example, running `continue` stops the debugger for
performance if there's no active breakpoints or catchpoints.
    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    d49fe2c View commit details
    Browse the repository at this point in the history

  18. Remove unnecessary Byebug.start 

    Causing remote debugging to be very slow.
    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    3dc1e79 View commit details
    Browse the repository at this point in the history

  19. Log commands in CI script

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    9ea4837 View commit details
    Browse the repository at this point in the history

  20. See if greater timeout works on Windows

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    cafc309 View commit details
    Browse the repository at this point in the history

  21. remote_test.rb - windows - add -I ruby parameter, change fork to thread

    @MSP-Greg @deivid-rodriguez
    MSP-Greg authored and deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    e38b585 View commit details
    Browse the repository at this point in the history

  22. Update interfaces/remote_interface.rb for Windows

    @MSP-Greg @deivid-rodriguez
    MSP-Greg authored and deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    4ee6d45 View commit details
    Browse the repository at this point in the history

  23. Refactor

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    223ea91 View commit details
    Browse the repository at this point in the history

  24. Further refactor

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    0182286 View commit details
    Browse the repository at this point in the history

  25. Increase and normalize timeouts 

    Sometimes tests time out on Linux too.
    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    dd7548f View commit details
    Browse the repository at this point in the history

  26. Fix windows check

    @deivid-rodriguez
    deivid-rodriguez committed Jan 13, 2018
    Configuration menu
    Copy the full SHA
    8359dfe View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Rescue the same stuff everywhere

    @deivid-rodriguez
    deivid-rodriguez committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    62fbd43 View commit details
    Browse the repository at this point in the history