Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor invisible when byebug used inside minitest Progress reporter #170

Closed
JoeCohen opened this issue Sep 2, 2015 · 4 comments
Closed

Comments

@JoeCohen
Copy link

JoeCohen commented Sep 2, 2015

When I set a breakpoint in a rails app using byebug and run tests using minitest-reporters' Progress reporter,
then there is no cursor in byebug when the test hits a breakpoint.
In the Default reporter, the cursor behave properly.
(Rails 4.0.13, ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-linux], minitest 4.7.5, minitest-reporters 0.14.24).

I originally reported this as an issue for minitest-reporters. The developer suggests: "byebug should be ready for situations when cursor is hidden by the program user debug and restore it." See here. Makes sense to me as minitest does not know what the user might doing inside it.

(Sorry for merely creating an issue -- as opposed to trying to fix it -- but I have no idea how to fix the Progress reporter so this doesn't happen.)

@deivid-rodriguez
Copy link
Owner

Maybe related to #59 and #63? Thanks for the report.

@deivid-rodriguez
Copy link
Owner

@JoeCohen Can you reproduce this issue against latest master? If yes, could you provide me with a way of seeing it happening myself?

@JoeCohen
Copy link
Author

JoeCohen commented Feb 9, 2016

David:
Thanks for following up, and sorry it took me so long to reply.
I have not seen this issue for a long time. I forget when it disappeared.
I am currently using:

ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux], with the patch
you described in h
ttps://github.com//issues/189#issue-117556534
byebug 8.2.1
minitest (5.8.3),
minitest-reporters (1.1.7)

Regards,
-- Joe

On Thu, Feb 4, 2016 at 7:39 AM David Rodríguez notifications@github.com
wrote:

@JoeCohen https://github.com/JoeCohen Can you reproduce this issue
against latest master? If yes, could you provide me with a way of seeing it
happening myself?


Reply to this email directly or view it on GitHub
#170 (comment)
.

@deivid-rodriguez
Copy link
Owner

Funny, I was hoping some unreleased commits would've fixed it... but since it's not happening anymore anyways I'll close. Please reopen if it reappears.

Salud!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants