adding oesign signing engine test #1428
Conversation
tools/myst/host/package.c
Outdated
| argv[0], | ||
| "sign", | ||
| rootfs_file, | ||
| pem_file, // TODO: maybe I need to take this out |
There was a problem hiding this comment.
Can you make this null and see if it works? You should not need a pem file.
There was a problem hiding this comment.
Does oesign need a pem file with the signing engine?
There was a problem hiding this comment.
It does not need one, null seems to work. Will remove the comment. The thing here is we use positional arguments, so if we do not have a pem file it would potentially be a breaking change for everyone..
There was a problem hiding this comment.
Can we let people specify "NULL" as a command line param.
There was a problem hiding this comment.
Definitely, they can already do that. Tested it out
There was a problem hiding this comment.
Added that to this test so we can maintain is as the recommended way to use signing engines
|
As we are testing |
| @@ -497,6 +498,7 @@ int _sign(int argc, const char* argv[]) | |||
| pem_file, | |||
| NULL, | |||
| NULL, | |||
| NULL, | |||
There was a problem hiding this comment.
Did the oesign() signature change?
salsal97
force-pushed
the
signing-engine
branch
from
48a00b4
to
e0bf867
Compare
This test tests the mystikos support for signing engine via oesign. Adopted from https://github.com/openenclave/openenclave/pull/2455/files.