-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syslog level configuration and add info logs during startup #1426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vtikoo for adding this. Can you also document your config additions here: https://github.com/deislabs/mystikos/blob/main/doc/sign-package.md (I dont know where CLI is documented)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Vikas. Two things:
- See minor comments
- Might be nice to show --syslog-level
option in the --help
.
Thank you for doing this.
the main kernel log reporter You can remove |
- Syslog level can be specified either via --syslog-level command line option or SyslogLevel in the JSON configuration. - Added info logs on mystikos kernel entry and before jumping to C runtime. These can be helpful to debug startup failures. Signed-off-by: Vikas Tikoo <vikasamar@gmail.com>
6654c6f
to
c0572c9
Compare
Thanks @radhikaj, had forgotten about updating the packaging docs. The CLI option is documented in the usage/help string. |
Thanks for sharing this @paulcallen. Had to change warning to warn to match with these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Vikas for doing this. Looks great. I am approving but not sure if others have outstanding requetss.
Summary
Signed-off-by: Vikas Tikoo vikasamar@gmail.com