Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syslog level configuration and add info logs during startup #1426

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

vtikoo
Copy link
Collaborator

@vtikoo vtikoo commented Sep 28, 2022

Summary

  • Syslog level can be specified either via --syslog-level command line option or SyslogLevel in the JSON configuration.
  • Added info logs on mystikos kernel entry and before jumping to C runtime. These can be helpful to debug startup failures.

Signed-off-by: Vikas Tikoo vikasamar@gmail.com

Copy link
Collaborator

@radhikaj radhikaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vtikoo for adding this. Can you also document your config additions here: https://github.com/deislabs/mystikos/blob/main/doc/sign-package.md (I dont know where CLI is documented)

Copy link
Contributor

@mikbras mikbras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Vikas. Two things:
- See minor comments
- Might be nice to show --syslog-level option in the --help.

Thank you for doing this.

kernel/enter.c Show resolved Hide resolved
tools/myst/config.c Outdated Show resolved Hide resolved
tools/myst/enc/enc.c Show resolved Hide resolved
@paulcallen
Copy link
Member

the main kernel log reporter dmesg allows you to specify which specific levels you want like this:
sudo dmesg --level=emerg,alert,crit,err,warn,notice,info,debug

You can remove err and display everything but that!

- Syslog level can be specified either via --syslog-level command line
option or SyslogLevel in the JSON configuration.

- Added info logs on mystikos kernel entry and before jumping to C
runtime. These can be helpful to debug startup failures.

Signed-off-by: Vikas Tikoo <vikasamar@gmail.com>
@vtikoo
Copy link
Collaborator Author

vtikoo commented Sep 28, 2022

Thanks @vtikoo for adding this. Can you also document your config additions here: https://github.com/deislabs/mystikos/blob/main/doc/sign-package.md (I dont know where CLI is documented)

Thanks @radhikaj, had forgotten about updating the packaging docs. The CLI option is documented in the usage/help string.

@vtikoo
Copy link
Collaborator Author

vtikoo commented Sep 28, 2022

the main kernel log reporter dmesg allows you to specify which specific levels you want like this: sudo dmesg --level=emerg,alert,crit,err,warn,notice,info,debug

Thanks for sharing this @paulcallen. Had to change warning to warn to match with these.

Copy link
Contributor

@mikbras mikbras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vikas for doing this. Looks great. I am approving but not sure if others have outstanding requetss.

@vtikoo vtikoo merged commit 7cd54b6 into deislabs:main Sep 29, 2022
@vtikoo vtikoo deleted the syslog-option branch September 29, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants